zeroshade commented on code in PR #33735:
URL: https://github.com/apache/arrow/pull/33735#discussion_r1073715515
##########
go/arrow/flight/server.go:
##########
@@ -64,6 +63,24 @@ func RegisterFlightServiceServer(s grpc.ServiceRegistrar,
srv FlightServer) {
flight.RegisterFlightServiceServer(s, srv)
}
+// From
https://github.com/grpc/grpc-go/blob/4c776ec01572d55249df309251900554b46adb41/reflection/serverreflection.go#L69-L83
+// See "google.golang.org/grpc/reflection" 's reflection.ServiceInfoProvider
+// ServiceInfoProvider is an interface used to retrieve metadata about the
+// services to expose.
+//
+// The reflection service is only interested in the service names, but the
+// signature is this way so that *grpc.Server implements it. So it is okay
+// for a custom implementation to return zero values for the
+// grpc.ServiceInfo values in the map.
+//
+// Experimental
+//
+// Notice: This type is EXPERIMENTAL and may be changed or removed in a
+// later release.
+type serviceInfoProvider interface {
+ GetServiceInfo() map[string]grpc.ServiceInfo
+}
Review Comment:
Can you add a small comment about the fact that we're inlining this in order
to provide compatibility with grpc < 1.45?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
