felipecrv commented on code in PR #33641: URL: https://github.com/apache/arrow/pull/33641#discussion_r1073830197
########## cpp/src/arrow/array/array_encoded.h: ########## @@ -0,0 +1,91 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// Array accessor classes run-end encoded arrays + +#pragma once + +#include <cstdint> +#include <memory> +#include <string> +#include <utility> +#include <vector> + +#include "arrow/array/array_base.h" +#include "arrow/array/data.h" +#include "arrow/result.h" +#include "arrow/status.h" +#include "arrow/type.h" +#include "arrow/type_fwd.h" +#include "arrow/util/checked_cast.h" +#include "arrow/util/macros.h" +#include "arrow/util/visibility.h" + +namespace arrow { + +/// \addtogroup encoded-arrays +/// +/// @{ + +// ---------------------------------------------------------------------- +// RunEndEncoded + +/// \brief Array type for run-end encoded data +class ARROW_EXPORT RunEndEncodedArray : public Array { + public: + using TypeClass = RunEndEncodedType; + + explicit RunEndEncodedArray(const std::shared_ptr<ArrayData>& data); + + RunEndEncodedArray(const std::shared_ptr<DataType>& type, int64_t logical_length, + const std::shared_ptr<Array>& run_ends, + const std::shared_ptr<Array>& values, int64_t offset = 0); + + /// \brief Construct a RunEndEncodedArray from values and run ends arrays + /// + /// The data type is automatically inferred from the arguments. + /// The run_ends and values arrays must have the same length. + static Result<std::shared_ptr<RunEndEncodedArray>> Make( + const std::shared_ptr<Array>& run_ends, const std::shared_ptr<Array>& values, + int64_t logical_length, int64_t offset = 0); + + /// \brief Returns an array holding the logical indexes of each run-end + /// + /// The physical offset to the array is applied. + std::shared_ptr<Array> run_ends_array() const; + + /// \brief Returns an array holding the values of each run + /// + /// The physical offset to the array is applied. + std::shared_ptr<Array> values_array() const; + + /// \brief Find the physical offset of the REE array + /// + /// This function uses binary-search, so it has a O(log N) cost. + int64_t FindPhysicalOffset() const; + + /// \brief Find the physical length of the REE array + /// + /// Avoid calling this function if the physical length can be estabilished in + /// some other way. This function uses binary-search, so it has a O(log N) + /// cost. Review Comment: "physical length" is the number of integers in the `run_ends` array. I don't understand why this had to be implemented with a search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
