viirya commented on code in PR #3553:
URL: https://github.com/apache/arrow-rs/pull/3553#discussion_r1073911714
##########
arrow-array/src/array/mod.rs:
##########
@@ -579,6 +582,20 @@ pub fn make_array(data: ArrayData) -> ArrayRef {
}
dt => panic!("Unexpected dictionary key type {:?}", dt),
},
+ DataType::RunEndEncoded(ref run_ends_type, _) => {
+ match run_ends_type.data_type() {
+ DataType::Int16 => {
+ Arc::new(RunEndEncodedArray::<Int16Type>::from(data)) as
ArrayRef
+ }
+ DataType::Int32 => {
+ Arc::new(RunEndEncodedArray::<Int32Type>::from(data)) as
ArrayRef
+ }
+ DataType::Int64 => {
+ Arc::new(RunEndEncodedArray::<Int64Type>::from(data)) as
ArrayRef
+ }
+ _ => unreachable!(),
Review Comment:
```suggestion
dt => panic!("Unexpected run-ends type {:?}", dt),,
```
##########
arrow-array/src/array/mod.rs:
##########
@@ -579,6 +582,20 @@ pub fn make_array(data: ArrayData) -> ArrayRef {
}
dt => panic!("Unexpected dictionary key type {:?}", dt),
},
+ DataType::RunEndEncoded(ref run_ends_type, _) => {
+ match run_ends_type.data_type() {
+ DataType::Int16 => {
+ Arc::new(RunEndEncodedArray::<Int16Type>::from(data)) as
ArrayRef
+ }
+ DataType::Int32 => {
+ Arc::new(RunEndEncodedArray::<Int32Type>::from(data)) as
ArrayRef
+ }
+ DataType::Int64 => {
+ Arc::new(RunEndEncodedArray::<Int64Type>::from(data)) as
ArrayRef
+ }
+ _ => unreachable!(),
Review Comment:
```suggestion
dt => panic!("Unexpected run-ends type {:?}", dt),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
