wjones127 commented on PR #33731:
URL: https://github.com/apache/arrow/pull/33731#issuecomment-1396074423

   Testing locally, this doesn't seem to have a meaningful performance impact:
   
   ```
   
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   Non-regressions: (20)
   
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                                                      benchmark      baseline   
  contender  change %                                                           
                                                                                
                                                         counters
       AllocateTouchDeallocate<SystemAlloc>/size:4096/real_time    204.664099   
 210.051257     2.632  {'family_index': 2, 'per_family_instance_index': 0, 
'run_name': 'AllocateTouchDeallocate<SystemAlloc>/size:4096/real_time', 
'repetitions': 10, 'repetition_index': 8, 'threads': 1, 'iterations': 3426305}
        AllocateDeallocate<SystemAlloc>/size:16777216/real_time    268.668581   
 275.188987     2.427   {'family_index': 1, 'per_family_instance_index': 3, 
'run_name': 'AllocateDeallocate<SystemAlloc>/size:16777216/real_time', 
'repetitions': 10, 'repetition_index': 3, 'threads': 1, 'iterations': 2586670}
                                  TouchArea/size:4096/real_time    104.906135   
 107.346276     2.326                             {'family_index': 0, 
'per_family_instance_index': 0, 'run_name': 'TouchArea/size:4096/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 6503239}
            AllocateDeallocate<SystemAlloc>/size:4096/real_time     81.298200   
  82.528759     1.514       {'family_index': 1, 'per_family_instance_index': 0, 
'run_name': 'AllocateDeallocate<SystemAlloc>/size:4096/real_time', 
'repetitions': 10, 'repetition_index': 1, 'threads': 1, 'iterations': 8574009}
           AllocateDeallocate<SystemAlloc>/size:65536/real_time     86.242152   
  87.317544     1.247      {'family_index': 1, 'per_family_instance_index': 1, 
'run_name': 'AllocateDeallocate<SystemAlloc>/size:65536/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 8032808}
                                 TouchArea/size:65536/real_time   2065.637857   
2089.153075     1.138                             {'family_index': 0, 
'per_family_instance_index': 1, 'run_name': 'TouchArea/size:65536/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 338534}
                               TouchArea/size:1048576/real_time  33561.687758  
33897.958823     1.002                            {'family_index': 0, 
'per_family_instance_index': 2, 'run_name': 'TouchArea/size:1048576/real_time', 
'repetitions': 10, 'repetition_index': 0, 'threads': 1, 'iterations': 20904}
         AllocateDeallocate<SystemAlloc>/size:1048576/real_time     86.329281   
  87.151204     0.952    {'family_index': 1, 'per_family_instance_index': 2, 
'run_name': 'AllocateDeallocate<SystemAlloc>/size:1048576/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 8052877}
                              TouchArea/size:16777216/real_time 551992.977624 
554943.583726     0.535                            {'family_index': 0, 
'per_family_instance_index': 3, 'run_name': 
'TouchArea/size:16777216/real_time', 'repetitions': 10, 'repetition_index': 6, 
'threads': 1, 'iterations': 1246}
               AllocateDeallocate<Mimalloc>/size:4096/real_time    611.195491   
 613.837637     0.432          {'family_index': 3, 'per_family_instance_index': 
0, 'run_name': 'AllocateDeallocate<Mimalloc>/size:4096/real_time', 
'repetitions': 10, 'repetition_index': 7, 'threads': 1, 'iterations': 1129148}
    AllocateTouchDeallocate<SystemAlloc>/size:1048576/real_time  33637.068404  
33742.818697     0.314 {'family_index': 2, 'per_family_instance_index': 2, 
'run_name': 'AllocateTouchDeallocate<SystemAlloc>/size:1048576/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 20786}
      AllocateTouchDeallocate<SystemAlloc>/size:65536/real_time   2178.021521   
2184.250021     0.286  {'family_index': 2, 'per_family_instance_index': 1, 
'run_name': 'AllocateTouchDeallocate<SystemAlloc>/size:65536/real_time', 
'repetitions': 10, 'repetition_index': 8, 'threads': 1, 'iterations': 301956}
            AllocateDeallocate<Mimalloc>/size:1048576/real_time  49273.256884  
49396.177104     0.249         {'family_index': 3, 'per_family_instance_index': 
2, 'run_name': 'AllocateDeallocate<Mimalloc>/size:1048576/real_time', 
'repetitions': 10, 'repetition_index': 5, 'threads': 1, 'iterations': 13986}
              AllocateDeallocate<Mimalloc>/size:65536/real_time   3593.347898   
3598.912585     0.155          {'family_index': 3, 'per_family_instance_index': 
1, 'run_name': 'AllocateDeallocate<Mimalloc>/size:65536/real_time', 
'repetitions': 10, 'repetition_index': 8, 'threads': 1, 'iterations': 194419}
         AllocateTouchDeallocate<Mimalloc>/size:65536/real_time   4172.062963   
4178.303784     0.150     {'family_index': 4, 'per_family_instance_index': 1, 
'run_name': 'AllocateTouchDeallocate<Mimalloc>/size:65536/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 166754}
      AllocateTouchDeallocate<Mimalloc>/size:16777216/real_time 945658.178997 
947048.350806     0.147     {'family_index': 4, 'per_family_instance_index': 3, 
'run_name': 'AllocateTouchDeallocate<Mimalloc>/size:16777216/real_time', 
'repetitions': 10, 'repetition_index': 0, 'threads': 1, 'iterations': 729}
       AllocateTouchDeallocate<Mimalloc>/size:1048576/real_time  58226.434250  
58305.874371     0.136    {'family_index': 4, 'per_family_instance_index': 2, 
'run_name': 'AllocateTouchDeallocate<Mimalloc>/size:1048576/real_time', 
'repetitions': 10, 'repetition_index': 9, 'threads': 1, 'iterations': 11955}
          AllocateTouchDeallocate<Mimalloc>/size:4096/real_time    736.315782   
 736.488692     0.023      {'family_index': 4, 'per_family_instance_index': 0, 
'run_name': 'AllocateTouchDeallocate<Mimalloc>/size:4096/real_time', 
'repetitions': 10, 'repetition_index': 5, 'threads': 1, 'iterations': 948133}
           AllocateDeallocate<Mimalloc>/size:16777216/real_time 756510.580898 
746775.527627    -1.287          {'family_index': 3, 
'per_family_instance_index': 3, 'run_name': 
'AllocateDeallocate<Mimalloc>/size:16777216/real_time', 'repetitions': 10, 
'repetition_index': 2, 'threads': 1, 'iterations': 892}
   AllocateTouchDeallocate<SystemAlloc>/size:16777216/real_time 562993.345414 
554626.038461    -1.486 {'family_index': 2, 'per_family_instance_index': 3, 
'run_name': 'AllocateTouchDeallocate<SystemAlloc>/size:16777216/real_time', 
'repetitions': 10, 'repetition_index': 0, 'threads': 1, 'iterations': 1246}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to