emkornfield commented on code in PR #17877:
URL: https://github.com/apache/arrow/pull/17877#discussion_r1080681488
##########
cpp/src/parquet/column_reader.h:
##########
@@ -367,6 +368,7 @@ class PARQUET_EXPORT RecordReader {
uint8_t* values() const { return values_->mutable_data(); }
/// \brief Number of values written including nulls (if any)
+ /// If read_dense_for_nullable_ is true this will not include nulls.
Review Comment:
nit: please try to phrase things relative to publicly visible APIs. E.g. if
this Reader was constructed with read_dense_for_nullable set to true. I think
rephrasing the `\brief` a little bit could make sense since we essentially
contradict (including nulls) if any on the very next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
