westonpace commented on code in PR #33725:
URL: https://github.com/apache/arrow/pull/33725#discussion_r1080698976
##########
docs/source/cpp/streaming_execution.rst:
##########
@@ -113,12 +109,12 @@ Read Relations
* The ``projection`` property is not supported and plans containing this
property will be rejected.
- * The only supported read type is ``LocalFiles``. Plans with any other
- type will be rejected.
- * Only the parquet file format is currently supported.
+ * The only ``VirtualTable`` and ``ExtensionTable``read types are not
supported.
Review Comment:
I think we catch this already. This is currently checked here (in
relation_internal.cc):
```
if (!read.has_local_files()) {
return Status::NotImplemented(
"substrait::ReadRel with read_type other than LocalFiles");
}
```
It might be nice to say "LocalFiles or NamedTable".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
