westonpace commented on code in PR #33738:
URL: https://github.com/apache/arrow/pull/33738#discussion_r1080701548
##########
cpp/src/arrow/compute/exec/sink_node.cc:
##########
@@ -335,19 +327,13 @@ class ConsumingSinkNode : public ExecNode, public
BackpressureControl {
void Resume() override { inputs_[0]->ResumeProducing(this,
++backpressure_counter_); }
void StopProducing() override {
- EVENT(span_, "StopProducing");
if (input_counter_.Cancel()) {
Finish(Status::OK());
}
}
void InputReceived(ExecNode* input, ExecBatch batch) override {
- EVENT(span_, "InputReceived", {{"batch.length", batch.length}});
- util::tracing::Span span;
- START_COMPUTE_SPAN_WITH_PARENT(
- span, span_, "InputReceived",
- {{"node.label", label()}, {"batch.length", batch.length}});
-
+ auto scope = TraceInputReceived(batch);
Review Comment:
The backpressure is applied in the dataset writer (it has it's own queue).
However, we can add tracing events in the dataset writer. I'm kind of
interested now to see what a dataset writer trace looks like. I will add
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
