joosthooz commented on code in PR #33738:
URL: https://github.com/apache/arrow/pull/33738#discussion_r1081097788
##########
cpp/src/arrow/compute/exec/sink_node.cc:
##########
@@ -335,19 +327,13 @@ class ConsumingSinkNode : public ExecNode, public
BackpressureControl {
void Resume() override { inputs_[0]->ResumeProducing(this,
++backpressure_counter_); }
void StopProducing() override {
- EVENT(span_, "StopProducing");
if (input_counter_.Cancel()) {
Finish(Status::OK());
}
}
void InputReceived(ExecNode* input, ExecBatch batch) override {
- EVENT(span_, "InputReceived", {{"batch.length", batch.length}});
- util::tracing::Span span;
- START_COMPUTE_SPAN_WITH_PARENT(
- span, span_, "InputReceived",
- {{"node.label", label()}, {"batch.length", batch.length}});
-
+ auto scope = TraceInputReceived(batch);
Review Comment:
Yes, I think that makes a lot of sense especially because the dataset writer
submits tasks to the IO executor that can run in parallel. All that would
otherwise be lost behind a single ConsumingSinkNode span
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
