jorisvandenbossche commented on code in PR #15196:
URL: https://github.com/apache/arrow/pull/15196#discussion_r1081408579
##########
python/pyarrow/_flight.pyx:
##########
@@ -536,12 +545,7 @@ cdef class FlightDescriptor(_Weakrefable):
return self.descriptor.path
def __repr__(self):
- if self.descriptor_type == DescriptorType.PATH:
- return "<FlightDescriptor path: {!r}>".format(self.path)
- elif self.descriptor_type == DescriptorType.CMD:
- return "<FlightDescriptor command: {!r}>".format(self.command)
- else:
- return "<FlightDescriptor type: {!r}>".format(self.descriptor_type)
+ return frombytes(self.descriptor.ToString())
Review Comment:
We also added "pyarrow." in front of the class names. For those flight
specific classes, that might be less needed (in comparison to the generic
"Buffer", for which it is useful to know it is a pyarrow Buffer), and would
also get lengthier ("pyarrow.flight.Action ..")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
