lidavidm commented on code in PR #355:
URL: https://github.com/apache/arrow-adbc/pull/355#discussion_r1081851233
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -103,6 +103,12 @@ func (d Driver) NewDatabase(opts map[string]string)
(adbc.Database, error) {
return nil, adbc.Error{Msg: err.Error(), Code:
adbc.StatusInvalidArgument}
}
+ if db.uri.Scheme == "grpc+tls" {
+ db.creds = credentials.NewTLS(&tls.Config{})
+ } else {
+ db.creds = insecure.NewCredentials()
+ }
Review Comment:
Done.
##########
ci/scripts/go_build.sh:
##########
@@ -42,6 +42,13 @@ main() {
make all
popd
+
+ mkdir -p "${install_dir}/lib"
+ if [[ $(go env GOOS) == "linux" ]]; then
+ cp ./pkg/libadbc_driver_flightsql_go.so "${install_dir}/lib"
+ else
+ cp ./pkg/libadbc_driver_flightsql_go.dylib "${install_dir}/lib"
Review Comment:
I removed them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
