westonpace commented on PR #33738: URL: https://github.com/apache/arrow/pull/33738#issuecomment-1397632804
@joosthooz I slightly changed things so the current task will be used as parent and not the scheduler. This makes it more clear that WriteAndCheckBackpressure is actually creating some of those following spans. However, at this point, I think we are veering from my original goal which was "remove the dependence on the exec node finished future so I can get away with it but don't break OT worse than it already was". I think I'd like to merge this in as it is. Would you be interested in investigating better ways of handling spans in a future PR? > Shouldn't there also be a span created in the delta that gets submitted to the IO executor in WriteNext? That's where the actual writing (and parquet encoding & compression) is being performed I think I/O of any kind is generally interesting enough to always justify a span. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
