avantgardnerio commented on code in PR #572:
URL: https://github.com/apache/arrow-ballista/pull/572#discussion_r1081883509
##########
ballista/core/src/lib.rs:
##########
@@ -29,6 +29,7 @@ pub mod event_loop;
pub mod execution_plans;
/// some plugins
pub mod plugin;
+pub mod test_util;
Review Comment:
It seems questionable to export test dependencies as part of the main
artifact. Perhaps a `#[cfg(test)]` would resolve that?
##########
examples/Cargo.toml:
##########
@@ -35,6 +35,7 @@ required-features = ["ballista/standalone"]
[dependencies]
ballista = { path = "../ballista/client", version = "0.10.0" }
+ballista-core = { path = "../ballista/core", version = "0.10.0" }
Review Comment:
Same... but `[test-dependencies]`... or maybe we need a `datafusion-test`
package. I'm curious to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
