wjones127 commented on issue #33618: URL: https://github.com/apache/arrow/issues/33618#issuecomment-1397675298
> Would it make sense to add something such that for localfs we decide whether to use stat or readdir system call? Seems like it could make sense. > Is it feasible to add an argument to a function in arrow::fs that only applies to one of the filesystems and does nothing for the others? `LocalFileSystem` is a subclass of `FileSystem`. So one option is to add a separate method on `LocalFileSystem`, and have users downcast when they want to use that method. For example, see how LocalFileSystem implements it's specialized `Equals` method: https://github.com/apache/arrow/blob/bf8780d0ff794c50312d799a9e877430e99dcf8b/cpp/src/arrow/filesystem/localfs.cc#L294-L301 The other method is what you suggested, adding a `needs_extended_file_info` parameter to `FileSelector`. I don't have a strong opinion on which would be better right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
