avantgardnerio commented on code in PR #560:
URL: https://github.com/apache/arrow-ballista/pull/560#discussion_r1081894897
##########
ballista/scheduler/src/scheduler_server/mod.rs:
##########
@@ -97,17 +100,53 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerServer<T
}
}
+ pub fn with_session_builder(
Review Comment:
Probably not part of this PR, but I think it's wildly important we switch to
struct update syntax or a builder pattern to avoid the combinatorial explosion
of `new_with_xxx_and_yyy()` methods which are a constant source of conflicts
for me.
I did an issue search, I think it's covered by
https://github.com/apache/arrow-ballista/issues/479 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
