westonpace commented on code in PR #33770:
URL: https://github.com/apache/arrow/pull/33770#discussion_r1081979936
##########
cpp/src/arrow/dataset/scanner.cc:
##########
@@ -135,20 +136,19 @@ Result<std::shared_ptr<Schema>>
GetProjectedSchemaFromExpression(
const std::shared_ptr<Schema>& dataset_schema) {
// process resultant dataset_schema after projection
FieldVector project_fields;
+ std::set<std::string> field_names;
Review Comment:
> if someone cares about order that gets lost, or if there's a better way.
We very much care about order here :). Fortunately, `std::set` is an
ordered set so the order should not be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
