tustvold commented on issue #3520: URL: https://github.com/apache/arrow-rs/issues/3520#issuecomment-1398149195
I'm not sure you can implement ArrayAccessor for REEArray as it doesn't know its value type? This is fine imo, we don't implement ArrayAccessor for DictionaryArray for much the same reason. Providing an iterator abstraction, similar to TypedDictionaryArray, that downcasts the values and uses ArrayAccessor to "decode" the runs makes sense to me Most kernels I imagine will need custom logic to handle RunEncodedArrays, e.g. take will need to parse the runs array and compute a new set of runs along with the take indices to apply to the values array. Filter will need to do something similar. One thing to be extremely careful of, is to avoid generic code typed on both the key type and the value type - this explodes codegen and has caused a lot of pain with dictionaries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
