tustvold commented on code in PR #3574:
URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082574357
##########
parquet/src/errors.rs:
##########
@@ -17,12 +17,13 @@
//! Common Parquet errors and macros.
+use std::error::Error;
use std::{cell, io, result, str};
#[cfg(feature = "arrow")]
use arrow_schema::ArrowError;
-#[derive(Debug, PartialEq, Clone, Eq)]
Review Comment:
I worry that lulls people into a false sense of security, I would rather
scream test removal and see if that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
