mustafasrepo opened a new pull request, #5003: URL: https://github.com/apache/arrow-datafusion/pull/5003
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes [#4978](https://github.com/apache/arrow-datafusion/issues/4978) # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Currently, queries that contain `UNBOUNDED PRECEDING` as in their window frame bounds, like the one below ```sql SELECT SUM(c1) OVER (ORDER BY c3 RANGE BETWEEN UNBOUNDED PRECEDING AND 11 FOLLOWING) as a1 FROM aggregate_test_100 ``` run with `WindowAggExec`. However, many aggregators do not require the whole range in memory to calculate their results -- the above query can actually run with `BoundedWindowAggExec`. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> This PR adds support for bounded-memory execution of suitable window functions even when the start bound is `UNBOUNDED PRECEDING`. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> We added new tests that verify the updated (i.e. optimized) physical plan. We also added fuzzy window tests to generate window frame bounds with `UNBOUNDED PRECEDING`. Fuzzy tests can now generate window frame bounds in the form `RANGE BETWEEN N PRECEDING AND M PRECEDING` or `RANGE BETWEEN M FOLLOWING AND N FOLLOWING`, which increases effective coverage. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
