comphead commented on code in PR #3570:
URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082815909
##########
arrow-csv/src/writer.rs:
##########
@@ -88,6 +88,35 @@ where
lexical_to_string(c.value(i))
}
+fn invalid_cast_error(dt: String, col_index: usize, row_index: usize) ->
ArrowError {
+ let mut s = String::new();
Review Comment:
Thanks @tustvold
Reg to https://github.com/hoodie/concatenation_benchmarks-rs the format
macro is 5x slower than string push. But you right, the exception is evauluated
in `ok_or_else` whic is lazy and won't affect performance on millions of rows,
Will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
