alamb commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082954021
########## datafusion/core/tests/path_partition.rs: ########## @@ -204,7 +204,7 @@ async fn csv_filter_with_file_col() -> Result<()> { ); let result = ctx - .sql("SELECT c1, c2 FROM t WHERE date='2021-10-27' and date!=c1 LIMIT 5") + .sql("SELECT c1, c2 FROM t WHERE date='2021-10-27' and c1!='2021-10-27' LIMIT 5") Review Comment: I think the partitioning columns in a ListingTable are dictionary encoded and this test is verifying the encoding. I think we should put the test back (and gate it with a `#cfg` directive) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org