melgenek commented on PR #4834: URL: https://github.com/apache/arrow-datafusion/pull/4834#issuecomment-1398866125
> I have several changes I would like to make, but I also think we could make them as (fast) follow on PRs. Specifically: > 1. Don't orchestrate the postgres containers with rust test code, rather orchestrate outside (either with an existing container or github CI, and document what is needed). Making this change will avoid requiring docker to run the datafusion tests, > 2. Use the same normalization in postgres and non-postgres code (maybe by decreasing fidelity of datafusion test) > 3. Remove existing postgres python integration tests This sounds reasonable to me. I'll try to make prs for points 1 and 2 in the next few days. For now, I merge master into this branch, so that it is mergeable. > 🤔 it seems like https://github.com/risinglightdb/sqllogictest-rs/pull/154 may be related to this PR (they have factored out their own postgres driver) I saw this change, but I don't think that extraction is currently sufficient to fully replace implementation in this pr. The biggest part of the Postgres client is the results conversion. And if it is made pluggable into the client from `sqllogictest-rs`, then it would be almost like writing the whole client from scratch. It seems to me, that a good idea would be to make primitive type conversions pluggable, so that Datafusion can apply the same floating point approximations, etc. And `sqllogictest-rs` would use the primitive type conversions for composite types, like arrays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
