kou commented on code in PR #33805:
URL: https://github.com/apache/arrow/pull/33805#discussion_r1083143197
##########
docker-compose.yml:
##########
@@ -967,6 +970,31 @@ services:
-
${DOCKER_VOLUME_PREFIX}python-wheel-manylinux2014-ccache:/ccache:delegated
command: /arrow/ci/scripts/python_wheel_manylinux_build.sh
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux_2_28_x86_64?tab=tags
+ python-wheel-manylinux-2-28:
+ image: ${REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2-28-vcpkg-${VCPKG}
+ build:
+ args:
+ arch: ${ARCH}
+ arch_short: ${ARCH_SHORT}
+ base: quay.io/pypa/manylinux_2_28_${ARCH_ALIAS}:2023-01-14-103cb93
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ manylinux: 2_28
+ context: .
+ dockerfile: ci/docker/python-wheel-manylinux-x-y.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2-28-vcpkg-${VCPKG}
+ environment:
+ <<: *ccache
+ volumes:
+ - .:/arrow:delegated
+ -
${DOCKER_VOLUME_PREFIX}python-wheel-manylinux228-ccache:/ccache:delegated
+ command: /arrow/ci/scripts/python_wheel_manylinux_build.sh
+
+
+
Review Comment:
```suggestion
```
##########
docker-compose.yml:
##########
@@ -180,6 +181,8 @@ volumes:
name: maven-cache
python-wheel-manylinux2014-ccache:
name: python-wheel-manylinux2014-ccache
+ python-wheel-manylinux228-ccache:
+ name: python-wheel-manylinux228-ccache
Review Comment:
```suggestion
python-wheel-manylinux-2-28-ccache:
name: python-wheel-manylinux-2-28-ccache
```
##########
ci/docker/python-wheel-manylinux-x-y.dockerfile:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ARG arch
+ARG arch_short
+ARG manylinux
+
+ENV MANYLINUX_VERSION=${manylinux}
+
+# Install basic dependencies
+RUN yum install -y git flex curl autoconf zip perl-IPC-Cmd wget
+
+ENV HOST_PYTHON_VERSION=3.8
+RUN HOST_PYTHON_ROOT=$(find /opt/python -name cp${HOST_PYTHON_VERSION/./}-*)
&& \
+ echo "export PATH=$HOST_PYTHON_ROOT/bin:\$PATH" >> /python.sh
+
+# Install CMake
+# AWS SDK doesn't work with CMake=3.22 due to
https://gitlab.kitware.com/cmake/cmake/-/issues/22524
+ARG cmake=3.21.4
+COPY ci/scripts/install_cmake.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_cmake.sh ${arch} linux
${cmake} /usr/local
+
+# Install Ninja
+ARG ninja=1.10.2
+COPY ci/scripts/install_ninja.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_ninja.sh ${ninja} /usr/local
+
+# Install ccache
+ARG ccache=4.1
+COPY ci/scripts/install_ccache.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_ccache.sh ${ccache}
/usr/local
+
+RUN echo "Hello World"
Review Comment:
```suggestion
```
##########
ci/docker/python-wheel-manylinux-x-y.dockerfile:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ARG arch
+ARG arch_short
+ARG manylinux
+
+ENV MANYLINUX_VERSION=${manylinux}
+
+# Install basic dependencies
+RUN yum install -y git flex curl autoconf zip perl-IPC-Cmd wget
+
+ENV HOST_PYTHON_VERSION=3.8
+RUN HOST_PYTHON_ROOT=$(find /opt/python -name cp${HOST_PYTHON_VERSION/./}-*)
&& \
+ echo "export PATH=$HOST_PYTHON_ROOT/bin:\$PATH" >> /python.sh
Review Comment:
Does the following work?
```suggestion
ENV HOST_PYTHON_VERSION=3.8
ENV
PATH=/opt/python/cp${HOST_PYTHON_VERSION}-${HOST_PYTHON_VERSION}/bin:${PATH}
```
##########
ci/docker/python-wheel-manylinux-x-y.dockerfile:
##########
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+ARG base
+FROM ${base}
+
+ARG arch
+ARG arch_short
+ARG manylinux
+
+ENV MANYLINUX_VERSION=${manylinux}
+
+# Install basic dependencies
+RUN yum install -y git flex curl autoconf zip perl-IPC-Cmd wget
+
+ENV HOST_PYTHON_VERSION=3.8
+RUN HOST_PYTHON_ROOT=$(find /opt/python -name cp${HOST_PYTHON_VERSION/./}-*)
&& \
+ echo "export PATH=$HOST_PYTHON_ROOT/bin:\$PATH" >> /python.sh
+
+# Install CMake
+# AWS SDK doesn't work with CMake=3.22 due to
https://gitlab.kitware.com/cmake/cmake/-/issues/22524
+ARG cmake=3.21.4
+COPY ci/scripts/install_cmake.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_cmake.sh ${arch} linux
${cmake} /usr/local
+
+# Install Ninja
+ARG ninja=1.10.2
+COPY ci/scripts/install_ninja.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_ninja.sh ${ninja} /usr/local
+
+# Install ccache
+ARG ccache=4.1
+COPY ci/scripts/install_ccache.sh arrow/ci/scripts/
+RUN source /python.sh && /arrow/ci/scripts/install_ccache.sh ${ccache}
/usr/local
+
+RUN echo "Hello World"
+
+# Install vcpkg
+ARG vcpkg
+ARG glibc=2.28
Review Comment:
Why? Could you add the reason as a comment of this line?
##########
docker-compose.yml:
##########
@@ -967,6 +970,31 @@ services:
-
${DOCKER_VOLUME_PREFIX}python-wheel-manylinux2014-ccache:/ccache:delegated
command: /arrow/ci/scripts/python_wheel_manylinux_build.sh
+ # See available versions at:
+ # https://quay.io/repository/pypa/manylinux_2_28_x86_64?tab=tags
+ python-wheel-manylinux-2-28:
+ image: ${REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2-28-vcpkg-${VCPKG}
+ build:
+ args:
+ arch: ${ARCH}
+ arch_short: ${ARCH_SHORT}
+ base: quay.io/pypa/manylinux_2_28_${ARCH_ALIAS}:2023-01-14-103cb93
+ vcpkg: ${VCPKG}
+ python: ${PYTHON}
+ manylinux: 2_28
+ context: .
+ dockerfile: ci/docker/python-wheel-manylinux-x-y.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-python-${PYTHON}-wheel-manylinux-2-28-vcpkg-${VCPKG}
+ environment:
+ <<: *ccache
+ volumes:
+ - .:/arrow:delegated
+ -
${DOCKER_VOLUME_PREFIX}python-wheel-manylinux228-ccache:/ccache:delegated
Review Comment:
```suggestion
-
${DOCKER_VOLUME_PREFIX}python-wheel-manylinux-2-28-ccache:/ccache:delegated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
