zzzzwj commented on code in PR #33703:
URL: https://github.com/apache/arrow/pull/33703#discussion_r1083228089
##########
cpp/src/parquet/arrow/test_util.h:
##########
@@ -463,12 +463,16 @@ Status MakeEmptyListsArray(int64_t size,
std::shared_ptr<Array>* out_array) {
return Status::OK();
}
+// Please make sure that the return value should have an object assigned
explicitly
+// if you want to use the pointer contained.
Review Comment:
Oh, really sorry, it looks like I truly misunderstood your meaning. I
thought that you wanted me to verify all the ownership of functions that return
a shared_ptr. I'll have a careful check and then make a change on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
