rtpsw commented on code in PR #33676:
URL: https://github.com/apache/arrow/pull/33676#discussion_r1083312503
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -523,7 +523,8 @@ class ARROW_EXPORT AsofJoinNodeOptions : public
ExecNodeOptions {
///
/// \see `Keys` for details.
std::vector<Keys> input_keys;
- /// \brief Tolerance for inexact "on" key matching. Must be non-negative.
+ /// \brief Tolerance for inexact "on" key matching. Positive (resp.
negative) tolerance
+ /// is interpreted as a future (resp. past) as-of-join.
Review Comment:
I wouldn't say the PR is at odds because it takes the tolerance as a single
parameter, a positive or negative number, whereas pandas takes the tolerance as
two parameters, a positive number and a direction, even though the direction
defaults to backwards. We could make this PR take the tolerance as two
parameters if we want strict consistency. @icexelloss requested this
standardization and should be able to explain the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
