jorisvandenbossche commented on pull request #8557: URL: https://github.com/apache/arrow/pull/8557#issuecomment-724225124
I was going to propose to actually completely remove the `S3FSWrapper` call here (instead of only moving it after the other check). This class if from before my time, but as far as I understand, it was initially used to wrap s3fs filesystems (so they could be used in ParquetDataset). Later on, the fsspec filesystems (and thus s3fs as well) became actual pyarrow.filesystem.FileSystem subclasses, so they would be used directly in ParquetDataset. So in practice, this S3FSWrapper has not been in use for the last s3fs / fsspec releases. But this change to inherit from pyarrow is already more than 2 years old (eg https://github.com/intake/filesystem_spec/commit/f461317ef05bbf7fd3450ca44de4442bc22673a8), so I think in practice nobody is (should be) using such an old fsspec version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
