westonpace commented on code in PR #33806: URL: https://github.com/apache/arrow/pull/33806#discussion_r1083390389
########## cpp/src/arrow/compute/kernels/scalar_string_test.cc: ########## @@ -19,6 +19,7 @@ #include <string> #include <utility> #include <vector> +#include "arrow/compute/exec.h" Review Comment: Can you keep the includes grouped together? ########## cpp/src/gandiva/regex_functions_holder.cc: ########## @@ -17,15 +17,12 @@ #include "gandiva/regex_functions_holder.h" #include <regex> +#include "arrow/util/macros.h" Review Comment: I am not very familiar with the gandiva code base. Is it ok/normal to use Arrow macros here? I assume so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
