alamb commented on code in PR #5015: URL: https://github.com/apache/arrow-datafusion/pull/5015#discussion_r1083509656
########## datafusion/core/tests/sqllogictests/README.md: ########## @@ -46,16 +46,33 @@ cargo test -p datafusion --test sqllogictests -- information #### Running tests: Postgres compatibility -Test files that start with prefix `pg_compat_` verify compatibility with Postgres. -Datafusion runs these test files during normal sqllogictest runs. +Test files that start with prefix `pg_compat_` verify compatibility +with Postgres by running the same script files both with DataFusion and with Posgres -In order to run sqllogictests with Postgres execute: +In order to run the sqllogictests running against a previously running Postgres instance, do: ```shell -PG_COMPAT=true cargo test -p datafusion --test sqllogictests +PG_COMPAT=true PG_DSN="postgresql://[email protected]/postgres" cargo test -p datafusion --test sqllogictests ``` -This command requires a docker binary. Check that docker is properly installed with `which docker`. +The environemnt variables: + +1. `PG_COMPAT` instructs sqllogictest to run against Postgres (not DataFusion) +2. `PG_DSN` contains a `libpq` style connection string, whose format is described in Review Comment: I agree DSN likely not quite the right name. It seems that is perhaps an oracle term -- but the format is not the same https://www.siriusopensource.com/en-us/blog/oracle-postgresql-migration-using-ora2pg There doesn't seem to be a standard name for this -- postgres seem to call it a "connection string" https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-PQSETDBLOGIN I changed it it to PG_URI in 99a2efdb3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
