sjperkins commented on code in PR #33805:
URL: https://github.com/apache/arrow/pull/33805#discussion_r1084001253
##########
dev/tasks/tasks.yml:
##########
@@ -452,16 +452,18 @@ tasks:
{############################## Wheel Linux ##################################}
-{% for ci, arch, arch_alias, x_y, manylinux in [("github", "amd64", "x86_64",
"2_17", "2014"),
- ("travis", "arm64", "aarch64",
"2_17", "2014")] %}
- wheel-manylinux{{ manylinux }}-{{ python_tag }}-{{ arch }}:
+{% for ci, arch, arch_alias, x_y, manylinux_version, manylinux in [("github",
"amd64", "x86_64", "2_17", "2014", "manylinux2014"),
+ ("github",
"amd64", "x86_64", "2_28", "2-28", "manylinux_2_28"),
+ ("travis",
"arm64", "aarch64", "2_17", "2014", "manylinux2014"),
+ ("travis",
"arm64", "aarch64", "2_28", "2-28", "manylinux_2_28")] %}
+ wheel-{{ manylinux }}-{{ python_tag }}-{{ arch }}:
ci: "{{ ci }}"
template: python-wheels/{{ ci }}.linux.{{ arch }}.yml
params:
python_version: "{{ python_version }}"
- manylinux_version: "{{ manylinux }}"
+ manylinux_version: "{{ manylinux_version }}"
artifacts:
- - pyarrow-{no_rc_version}-{{ python_tag }}-{{ abi_tag }}-manylinux_{{
x_y }}_{{ arch_alias }}.manylinux{{ manylinux }}_{{ arch_alias }}.whl
+ - pyarrow-{no_rc_version}-{{ python_tag }}-{{ abi_tag }}-manylinux_{{
x_y }}_{{ arch_alias }}.{{ manylinux }}_{{ arch_alias }}.whl
Review Comment:
> it seems the new artifacts generated are not exactly matching this pattern
I think it's because `python-wheel-manylinux-2014` produces two tags when
passed through auditwheel
```bash
$ archery docker run python-wheel-manylinux-2014
...
+ echo '=== (3.8) Tag the wheel with manylinux2014 ==='
=== (3.8) Tag the wheel with manylinux2014 ===
+ auditwheel repair -L .
dist/pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-linux_x86_64.whl -w
repaired_wheels
INFO:auditwheel.main_repair:Repairing
pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-linux_x86_64.whl
INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
INFO:auditwheel.wheeltools:New filename tags: manylinux_2_17_x86_64,
manylinux2014_x86_64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp38-cp38-linux_x86_64
INFO:auditwheel.wheeltools:New WHEEL info tags:
cp38-cp38-manylinux_2_17_x86_64, cp38-cp38-manylinux2014_x86_64
INFO:auditwheel.main_repair:
Fixed-up wheel written to
/arrow/python/repaired_wheels/pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
+ popd
```
while `python-wheel-manylinux-2-28` only produces a single tag:
```bash
$ archery docker run python-wheel-manylinux-2014
...
+ echo '=== (3.8) Tag the wheel with manylinux228 ==='
=== (3.8) Tag the wheel with manylinux228 ===
+ auditwheel repair -L .
dist/pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-linux_x86_64.whl -w
repaired_wheels
INFO:auditwheel.main_repair:Repairing
pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-linux_x86_64.whl
INFO:auditwheel.wheeltools:Previous filename tags: linux_x86_64
INFO:auditwheel.wheeltools:New filename tags: manylinux_2_28_x86_64
INFO:auditwheel.wheeltools:Previous WHEEL info tags: cp38-cp38-linux_x86_64
INFO:auditwheel.wheeltools:New WHEEL info tags:
cp38-cp38-manylinux_2_28_x86_64
INFO:auditwheel.main_repair:
Fixed-up wheel written to
/arrow/python/repaired_wheels/pyarrow-11.0.0.dev13049+g46579ae.d20230123-cp38-cp38-manylinux_2_28_x86_64.whl
```
To me this suggests that the artifact pattern may need to accommodate both
cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
