wjones127 commented on code in PR #33694:
URL: https://github.com/apache/arrow/pull/33694#discussion_r1084258572
##########
cpp/src/parquet/properties.h:
##########
@@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties {
return this->disable_statistics(path->ToDotString());
}
- /// Enable integer type to annotate decimal type as below:
- /// int32: 1 <= precision <= 9
- /// int64: 10 <= precision <= 18
- /// Default disabled.
- Builder* enable_integer_annotate_decimal() {
- integer_annotate_decimal_ = true;
+ /// Enable decimal logical type with 1 <= precision <= 18 to be stored as
+ /// integer physical type.
+ ///
+ /// According to the specs, DECIMAL can be used to annotate the following
types:
+ /// - int32: for 1 <= precision <= 9.
+ /// - int64: for 1 <= precision <= 18; precision < 10 will produce a
warning.
Review Comment:
Then perhaps we should change to this? So that we document our libraries
behavior, and not just what the spec says?
```suggestion
/// - int64: for 10 <= precision <= 18.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
