emkornfield commented on a change in pull request #8516:
URL: https://github.com/apache/arrow/pull/8516#discussion_r520337463
##########
File path: cpp/src/parquet/column_writer.cc
##########
@@ -1190,7 +1192,7 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
int64_t* out_spaced_values_to_write,
int64_t* null_count) {
if (bits_buffer_ == nullptr) {
- if (!level_info_.HasNullableValues()) {
+ if (level_info_.def_level == 0) {
Review comment:
I added comments and a check. I document the method to make it clearer
that it always updates the output parameters as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
