roeap commented on code in PR #3581:
URL: https://github.com/apache/arrow-rs/pull/3581#discussion_r1084444924
##########
object_store/src/azure/credential.rs:
##########
@@ -273,7 +281,12 @@ fn lexy_sort<'a>(
values
}
-#[derive(serde::Deserialize, Debug)]
+#[async_trait::async_trait]
+pub trait TokenCredential: std::fmt::Debug + Send + Sync + 'static {
+ async fn fetch_token(&self, client: &Client, retry: &RetryConfig) ->
Result<String>;
Review Comment:
I passed in a client for the managed identity, but I was unsure about the
other credentials as they always use ssl. So we just ignore the client for the
managed identity. If however the "savings" of not having a redundant instance
of the client are not relevant, I'm happy to move it for all credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
