benibus commented on PR #15194: URL: https://github.com/apache/arrow/pull/15194#issuecomment-1401353769
This is ready for a second look. I switched over to using a `min_space_savings` percentage instead of just a boolean (the name is a bit weird, but it [supposedly has some precedence](https://en.wikipedia.org/wiki/Data_compression_ratio) so that's what I went with - no strong opinions though). I'm also not quite sure whether the parameter should be a literal `std::optional` or just `double = 0.0` by default. The effect should be the same either way. Some kind of range-validation is probably in order though, at least in debug mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
