kou commented on code in PR #378:
URL: https://github.com/apache/arrow-adbc/pull/378#discussion_r1084988849


##########
.github/workflows/native-unix.yml:
##########
@@ -290,17 +290,26 @@ jobs:
           BUILD_DRIVER_FLIGHTSQL: "1"
         run: |
           ./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
-      - name: Test FlightSQL Driver against Dremio
+      - name: Start sqlite server

Review Comment:
   ```suggestion
         - name: Start SQLite server
   ```



##########
.github/workflows/native-unix.yml:
##########
@@ -290,17 +290,26 @@ jobs:
           BUILD_DRIVER_FLIGHTSQL: "1"
         run: |
           ./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
-      - name: Test FlightSQL Driver against Dremio
+      - name: Start sqlite server
+        shell: bash -l {0}
+        run: |
+          docker-compose up -d golang-sqlite-flightsql
+      - name: Test FlightSQL Driver against Dremio and SQLite
         shell: bash -l {0}
         env:
           BUILD_ALL: "0"
           BUILD_DRIVER_FLIGHTSQL: "1"
           ADBC_DREMIO_FLIGHTSQL_URI: "grpc+tcp://localhost:32010"
           ADBC_DREMIO_FLIGHTSQL_USER: "dremio"
           ADBC_DREMIO_FLIGHTSQL_PASS: "dremio123"
+          ADBC_SQLITE_FLIGHTSQL_URI: "grpc+tcp://localhost:8080"
         run: |
           ./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
           ./ci/scripts/cpp_test.sh "$(pwd)" "$(pwd)/build"
+      - name: Stop sqlite server

Review Comment:
   ```suggestion
         - name: Stop SQLite server
   ```



##########
.env:
##########
@@ -31,6 +31,8 @@ JDK=8
 MANYLINUX=2014
 MAVEN=3.5.4
 PYTHON=3.10
+GO=1.19.5
+ARROW_MAJOR_VERSION=11

Review Comment:
   11 isn't tagged yet. (But it will be tagged in a few days.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to