tustvold commented on code in PR #3593:
URL: https://github.com/apache/arrow-rs/pull/3593#discussion_r1085141255
##########
arrow-array/src/array/string_array.rs:
##########
@@ -663,18 +620,28 @@ mod tests {
#[test]
#[should_panic(
- expected = "StringArray can only be created from List<u8> arrays,
mismatched data types."
+ expected = "BinaryArray can only be created from List<u8> arrays,
mismatched data types."
)]
fn test_string_array_from_list_array_wrong_type() {
_test_generic_string_array_from_list_array_wrong_type::<i32>();
}
#[test]
#[should_panic(
- expected = "StringArray can only be created from List<u8> arrays,
mismatched data types."
+ expected = "BinaryArray can only be created from List<u8> arrays,
mismatched data types."
)]
fn test_large_string_array_from_list_array_wrong_type() {
- _test_generic_string_array_from_list_array_wrong_type::<i32>();
+ _test_generic_string_array_from_list_array_wrong_type::<i64>();
Review Comment:
This was a mistake it wasn't actually testing large string array :scream:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
