akshaysu12 commented on PR #33761: URL: https://github.com/apache/arrow/pull/33761#issuecomment-1402072674
@AlenkaF thanks for the feedback! Sorry I've been sitting on this a bit because I'm not sure what to do about the read_options.use_threads. It looks like the one major difference from the CSV streaming reader. https://github.com/apache/arrow/pull/14355 indicates multiple threads can be used but there's no explicit documentation at `docs/source/cpp/json.rst`. The tests I've written in test_json.py pass if use_threads is False or True. It looks like `cpp/src/arrow/json/reader_test.cc` has more specific tests for the AsyncStreamingReader. 1. Do I need to write additional tests more specific to read_options.use_threads = True? 2. Do I need to include documentation on read_options.use_threads? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
