viirya commented on code in PR #3594:
URL: https://github.com/apache/arrow-rs/pull/3594#discussion_r1085703654
##########
arrow-flight/src/encode.rs:
##########
@@ -122,6 +125,15 @@ impl FlightDataEncoderBuilder {
self
}
+ /// Specify a schema for the RecordBatches being sent. If a schema
+ /// is not specified, an encoded Schema message will be sent when
+ /// the first [`RecordBatch`], if any, is encoded. Some clients
+ /// expect a Schema message even if there is no data sent.
+ pub fn with_schema(mut self, schema: SchemaRef) -> Self {
Review Comment:
I'm wondering if it will be more consistent to always require specifying
schema instead of two mixed approaches (specifying it by this, getting from
first RecordBatch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
