alamb commented on code in PR #5047:
URL: https://github.com/apache/arrow-datafusion/pull/5047#discussion_r1085763550
##########
.github/workflows/dev.yml:
##########
@@ -18,6 +18,10 @@
name: Dev
on: [push, pull_request]
+concurrency:
Review Comment:
I think adding rationale as comments will help avoid someone deleting this
by mistake as part of some future "cleanup"
```suggestion
# Ensure when changes are pushed to a PR previously running jobs are canceled
concurrency:
```
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -32,8 +32,17 @@ runs:
apt-get install -y protobuf-compiler
- name: Setup Rust toolchain
shell: bash
+ # rustfmt is needed for the substrait build script
run: |
echo "Installing ${{ inputs.rust-version }}"
rustup toolchain install ${{ inputs.rust-version }}
rustup default ${{ inputs.rust-version }}
rustup component add rustfmt
+ - name: Disable debuginfo generation
+ # Disable full debug symbol generation to speed up CI build and keep
memory down
Review Comment:
👍
##########
.github/workflows/rust.yml:
##########
@@ -478,19 +485,14 @@ jobs:
- name: Run tests
run: |
cd datafusion
- # Force all hash values to collide
- cargo test --all --features=force_hash_collisions
+ cargo test --lib --tests --features=force_hash_collisions
Review Comment:
agreed -- no need to run doc tests
##########
.github/workflows/rust.yml:
##########
@@ -17,6 +17,10 @@
name: Rust
+concurrency:
Review Comment:
```suggestion
# Ensure when changes are pushed to a PR previously running jobs are canceled
concurrency:
```
##########
.github/workflows/dev_pr.yml:
##########
@@ -17,6 +17,10 @@
name: Labeler
+concurrency:
Review Comment:
```suggestion
# Ensure when changes are pushed to a PR previously running jobs are canceled
concurrency:
```
##########
.github/workflows/rust.yml:
##########
@@ -356,10 +374,9 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- - name: Run tests
- run: |
- cd datafusion
- cargo test --features=pyarrow
+ - name: Run datafusion-common tests
+ run: cargo test -p datafusion-common --features=pyarrow
Review Comment:
I agree based on
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20pyarrow&type=code
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
