tustvold commented on code in PR #3600:
URL: https://github.com/apache/arrow-rs/pull/3600#discussion_r1085878319
##########
object_store/src/client/mod.rs:
##########
@@ -106,6 +107,13 @@ impl ClientOptions {
self.allow_http = allow_http;
self
}
+ /// Allows connections to invalid SSL certificates
+ /// * false (default): Only valid HTTPS certificates are allowed
+ /// * true: All HTTPS certificates are allowed. Only for testing purposes
+ pub fn with_allow_insecure(mut self, allow_insecure: bool) -> Self {
Review Comment:
```suggestion
pub fn with_allow_invalid_certificates(mut self, allow_insecure: bool)
-> Self {
```
##########
object_store/src/client/mod.rs:
##########
@@ -106,6 +107,13 @@ impl ClientOptions {
self.allow_http = allow_http;
self
}
+ /// Allows connections to invalid SSL certificates
+ /// * false (default): Only valid HTTPS certificates are allowed
+ /// * true: All HTTPS certificates are allowed. Only for testing purposes
Review Comment:
```suggestion
/// Allows connections to invalid SSL certificates
/// * false (default): Only valid HTTPS certificates are allowed
/// * true: All HTTPS certificates are allowed
///
/// # Warning
///
/// You should think very carefully before using this method. If
/// invalid certificates are trusted, *any* certificate for *any* site
/// will be trusted for use. This includes expired certificates. This
/// introduces significant vulnerabilities, and should only be used
/// as a last resort or for testing
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
