kou commented on code in PR #14561:
URL: https://github.com/apache/arrow/pull/14561#discussion_r1086202991
##########
docker-compose.yml:
##########
@@ -141,6 +141,7 @@ x-hierarchy:
- ubuntu-python-sdist-test
- ubuntu-r
- ubuntu-r-only-r
+ - ubuntu-swift
Review Comment:
```suggestion
- ubuntu-swift
```
(We need to put this between `ubuntu-r-valgrind` and `ubuntu-verify-rc` to
keep order.)
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
Review Comment:
```suggestion
archery docker run ubuntu-swift
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
+ - name: Setup Archery
+ run: pip install -e dev/archery[docker]
+ - name: Execute Docker Build
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ run: |
+ sudo sysctl -w kernel.core_pattern="core.%e.%p"
+ ulimit -c unlimited
+ archery docker run ${{ matrix.image }}
+ - name: Docker Push
+ if: success() && github.event_name == 'push' && github.repository ==
'apache/arrow'
+ env:
+ ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
+ ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
+ continue-on-error: true
+ run: archery docker push ${{ matrix.image }}
Review Comment:
```suggestion
run: archery docker push ubuntu-swift
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
Review Comment:
```suggestion
name: AMD 64 Ubuntu 20.04 Swift 5.7
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 15
```
##########
.github/workflows/swift.yml:
##########
@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Swift
+
+on:
+ push:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+ pull_request:
+ paths:
+ - '.github/workflows/swift.yml'
+ - 'ci/docker/**'
+ - 'ci/scripts/swift_*'
+ - 'swift/**'
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+env:
+ DOCKER_VOLUME_PREFIX: ".docker/"
+
+jobs:
+
+ docker:
+ name: ${{ matrix.title }}
+ runs-on: ubuntu-latest
+ if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
+ timeout-minutes: 60
+ strategy:
+ fail-fast: false
+ matrix:
+ name:
+ - swift-5-7-1
+ include:
+ - name: swift-5.7.1
+ cache: conda-swift-5.7.1
+ image: ubuntu-swift
+ title: Swift ubuntu
+ ubuntu:
+ - 20.04
+ env:
+ UBUNTU: ${{ matrix.ubuntu }}
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@v3
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Cache Docker Volumes
+ uses: actions/cache@v3
+ with:
+ path: .docker
+ key: ${{ matrix.cache }}-${{ hashFiles('swift/**') }}
+ restore-keys: ${{ matrix.cache }}-
Review Comment:
```suggestion
key: ubuntu-20.04-swift-${{ hashFiles('swift/**') }}
restore-keys: ubuntu-20.04-swift-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
