zeroshade commented on code in PR #387:
URL: https://github.com/apache/arrow-adbc/pull/387#discussion_r1087089283
##########
go/adbc/driver/flightsql/flightsql_adbc.go:
##########
@@ -635,6 +673,9 @@ func (c *cnxn) NewStatement() (adbc.Statement, error) {
alloc: c.db.alloc,
cl: c.cl,
clientCache: c.clientCache,
+ // don't copy the headers so that calling SetOption to add more
+ // headers on the connection still propagates
Review Comment:
That was how I originally implemented it.... haha. It's only when i copied
the old C++ tests that i changed it. I'll put it back :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
