kou commented on code in PR #33847:
URL: https://github.com/apache/arrow/pull/33847#discussion_r1087319273
##########
cpp/src/arrow/type.h:
##########
@@ -288,31 +288,46 @@ std::shared_ptr<DataType> GetPhysicalType(const
std::shared_ptr<DataType>& type)
class ARROW_EXPORT FixedWidthType : public DataType {
public:
using DataType::DataType;
+ // This is only for preventing defining this class in each
+ // translation unit to avoid one-definition-rule violation.
+ ~FixedWidthType() override;
Review Comment:
It seems that this is only happen with GCC (GNU ld?).
I couldn't reproduce this with `CC=clang CXX=clang++ CFLAGS="-flto"
CXXFLAGS="-flto" cmake ...`. (`W` symbol is still generated but there is no
link error.)
Is it acceptable that we add this change only for GCC and LTO?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
