westonpace commented on code in PR #15083:
URL: https://github.com/apache/arrow/pull/15083#discussion_r1088109062
##########
cpp/src/arrow/compute/exec.h:
##########
@@ -174,7 +175,10 @@ struct ARROW_EXPORT ExecBatch {
explicit ExecBatch(const RecordBatch& batch);
- static Result<ExecBatch> Make(std::vector<Datum> values);
+ /// \brief Infer the ExecBatch length from values.
+ static Result<int64_t> InferLength(const std::vector<Datum>& values);
Review Comment:
Yes, you're correct, this suggestion is in the wrong place. Given it's
internal you could probably use `//` and be more concise as well. At a glance
it wasn't obvious to me that the operation could "fail" and a small comment to
explain those scenarios would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
