nseekhao commented on code in PR #5077:
URL: https://github.com/apache/arrow-datafusion/pull/5077#discussion_r1088161686
##########
datafusion/substrait/tests/roundtrip.rs:
##########
@@ -306,7 +322,7 @@ mod tests {
explicit_options.schema = Some(&schema);
ctx.register_csv("data", "tests/testdata/data.csv",
explicit_options.clone())
.await?;
- ctx.register_csv("data2", "tests/testdata/data.csv", explicit_options)
+ ctx.register_csv("data2", "tests/testdata/data.csv",
explicit_options.clone())
Review Comment:
You're right. The second one is not needed, since we `clone`d the first one.
I also think the second call to `register_csv()` can just use the default
option since we're not using the second table to test `Decimal`s so I'll fix
that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
