melgenek commented on code in PR #5075: URL: https://github.com/apache/arrow-datafusion/pull/5075#discussion_r1088750304
########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T Review Comment: ```suggestion query I ``` There is currently no type check, but if this change ever lands https://github.com/risinglightdb/sqllogictest-rs/issues/36#issuecomment-1341031082, then it would be fewer changes during the sqllogictest-rs version update. ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T Review Comment: ```suggestion query I ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T Review Comment: ```suggestion query I ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T +SELECT 1 as x +UNION +SELECT 1 as x +---- +1 + +# union_all_with_aggregate +query T +SELECT SUM(d) FROM ( + SELECT 1 as c, 2 as d + UNION ALL + SELECT 1 as c, 3 AS d +) as a +---- +5 + +# union_all_with_count +statement ok +CREATE table t as SELECT 1 as a + +query T +SELECT COUNT(*) FROM ( + SELECT a from t + UNION ALL + SELECT a from t +) +---- +2 + +# union_schemas +query T Review Comment: ```suggestion query I ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T +SELECT 1 as x +UNION +SELECT 1 as x +---- +1 + +# union_all_with_aggregate +query T +SELECT SUM(d) FROM ( + SELECT 1 as c, 2 as d + UNION ALL + SELECT 1 as c, 3 AS d +) as a +---- +5 + +# union_all_with_count +statement ok +CREATE table t as SELECT 1 as a + +query T Review Comment: ```suggestion query I ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T +SELECT 1 as x +UNION +SELECT 1 as x +---- +1 + +# union_all_with_aggregate +query T Review Comment: ```suggestion query I ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T +SELECT 1 as x +UNION +SELECT 1 as x +---- +1 + +# union_all_with_aggregate +query T +SELECT SUM(d) FROM ( + SELECT 1 as c, 2 as d + UNION ALL + SELECT 1 as c, 3 AS d +) as a +---- +5 + +# union_all_with_count +statement ok +CREATE table t as SELECT 1 as a + +query T +SELECT COUNT(*) FROM ( + SELECT a from t + UNION ALL + SELECT a from t +) +---- +2 + +# union_schemas +query T +SELECT 1 A UNION ALL SELECT 2 order by 1 +---- +1 +2 + +# union_schemas +query T +SELECT 1 UNION SELECT 2 order by 1 +---- +1 +2 + +# union_with_except_input +query T +( + SELECT name FROM t1 + EXCEPT + SELECT name FROM t2 +) +UNION ALL +( + SELECT name FROM t2 + EXCEPT + SELECT name FROM t1 +) +---- +Alice +John + +# union_with_type_coercion +query T Review Comment: ```suggestion query IT ``` ########## datafusion/core/tests/sqllogictests/test_files/union.slt: ########## @@ -76,3 +74,121 @@ ORDER BY name ---- 3 Alice 3 John + +# union all +query T +SELECT 1 as x +UNION ALL +SELECT 2 as x +---- +1 +2 + +# csv_union_all +statement ok +CREATE EXTERNAL TABLE aggregate_test_100 ( + c1 VARCHAR NOT NULL, + c2 TINYINT NOT NULL, + c3 SMALLINT NOT NULL, + c4 SMALLINT, + c5 INT, + c6 BIGINT NOT NULL, + c7 SMALLINT NOT NULL, + c8 INT NOT NULL, + c9 BIGINT UNSIGNED NOT NULL, + c10 VARCHAR NOT NULL, + c11 FLOAT NOT NULL, + c12 DOUBLE NOT NULL, + c13 VARCHAR NOT NULL +) +STORED AS CSV +WITH HEADER ROW +LOCATION '../../testing/data/csv/aggregate_test_100.csv' + +query T +select COUNT(*) from ( + SELECT c1 FROM aggregate_test_100 + UNION ALL + SELECT c1 FROM aggregate_test_100 +) +---- +200 + +# union_distinct +query T +SELECT 1 as x +UNION +SELECT 1 as x +---- +1 + +# union_all_with_aggregate +query T +SELECT SUM(d) FROM ( + SELECT 1 as c, 2 as d + UNION ALL + SELECT 1 as c, 3 AS d +) as a +---- +5 + +# union_all_with_count +statement ok +CREATE table t as SELECT 1 as a + +query T +SELECT COUNT(*) FROM ( + SELECT a from t + UNION ALL + SELECT a from t +) +---- +2 + +# union_schemas +query T +SELECT 1 A UNION ALL SELECT 2 order by 1 +---- +1 +2 + +# union_schemas +query T Review Comment: ```suggestion query I ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
