tustvold commented on code in PR #3616:
URL: https://github.com/apache/arrow-rs/pull/3616#discussion_r1089030147
##########
arrow-array/src/builder/generic_bytes_dictionary_builder.rs:
##########
@@ -40,10 +40,10 @@ where
state: ahash::RandomState,
/// Used to provide a lookup from string value to key type
///
- /// Note: K's hash implementation is not used, instead the raw entry
+ /// Note: usize's hash implementation is not used, instead the raw entry
/// API is used to store keys w.r.t the hash of the strings themselves
///
- dedup: HashMap<K::Native, (), ()>,
+ dedup: HashMap<usize, (), ()>,
Review Comment:
This shaves off a further 1%, the primitive dictionary massively in terms of
codegen
##########
arrow-array/src/builder/generic_bytes_dictionary_builder.rs:
##########
@@ -40,10 +40,10 @@ where
state: ahash::RandomState,
/// Used to provide a lookup from string value to key type
///
- /// Note: K's hash implementation is not used, instead the raw entry
+ /// Note: usize's hash implementation is not used, instead the raw entry
/// API is used to store keys w.r.t the hash of the strings themselves
///
- dedup: HashMap<K::Native, (), ()>,
+ dedup: HashMap<usize, (), ()>,
Review Comment:
This shaves off a further 1%, the primitive dictionary dominates massively
in terms of codegen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
