mapleFU commented on PR #33897: URL: https://github.com/apache/arrow/pull/33897#issuecomment-1406679894
Well, by the way, I found a trickey issue. In `RowGroupSerializer`, it have both: ```c++ int64_t total_bytes_written() const override; ``` and member: ```c++ int64_t total_bytes_written_; ``` When `RowGroupSerializer` is closed, all bytes will accumulated to `total_bytes_written_`, and use it to finish metadata. But `total_bytes_written()` will always got 0. Should I add comment for this behavior? Or making it return `total_bytes_written_` once closed? @pitrou @wjones127 @wgtmac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
