alamb commented on pull request #8619:
URL: https://github.com/apache/arrow/pull/8619#issuecomment-725023738


   @jorgecarleitao  
   
   > What do you think of adding instructions on how to create the graphs in 
the README, or as an example?
   
   Great idea. I have added some instructions in 
https://github.com/apache/arrow/pull/8619/commits/b1965fae167ac46ff399752c55a8728b78de2bca
   
   > A minor concern is the file size: I would be supportive of moving the 
visitor to a different file, to avoid exploding this one even further. A later 
PR is also fine, though :P
   
   I will do so as a follow on PR after this is merged
   
   @andygrove  --  I will wait for your review / feedback before doing anything 
more with this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to