rtadepalli commented on PR #33822: URL: https://github.com/apache/arrow/pull/33822#issuecomment-1407414127
I think they should. I was looking at the implementation in Go as a reference, and it doesn't seem like the PR that introduced the change (https://github.com/apache/arrow/pull/13806) added any additional tests for finding the offset. I am of the idea right now that existing tests should break if this change is wrong. Please let me know if this is not true, and a unit test is warranted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
