rok commented on code in PR #14293:
URL: https://github.com/apache/arrow/pull/14293#discussion_r1089854498
##########
cpp/src/parquet/encoding.cc:
##########
@@ -3086,7 +3257,17 @@ std::unique_ptr<Encoder> MakeEncoder(Type::type
type_num, Encoding::type encodin
default:
throw ParquetException(
"DELTA_BINARY_PACKED encoder only supports INT32 and INT64");
- break;
+ }
+ } else if (encoding == Encoding::DELTA_LENGTH_BYTE_ARRAY) {
+ switch (type_num) {
+ case Type::BYTE_ARRAY:
+ return std::unique_ptr<Encoder>(
+ new DeltaLengthByteArrayEncoder<ByteArray>(descr, pool));
+ case Type::FIXED_LEN_BYTE_ARRAY:
+ return std::unique_ptr<Encoder>(
+ new DeltaLengthByteArrayEncoder<FLBAType>(descr, pool));
+ default:
+ throw ParquetException("DELTA_LENGTH_BYTE_ARRAY only supports
BYTE_ARRAY");
Review Comment:
I added the comment, but this doesn't support it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
