tustvold commented on code in PR #5102:
URL: https://github.com/apache/arrow-datafusion/pull/5102#discussion_r1089915062
##########
datafusion/core/src/physical_plan/metrics/mod.rs:
##########
@@ -161,8 +161,8 @@ impl Metric {
}
/// return a reference to the partition
- pub fn partition(&self) -> &Option<usize> {
- &self.partition
+ pub fn partition(&self) -> Option<&usize> {
+ self.partition.as_ref()
}
Review Comment:
```suggestion
pub fn partition(&self) -> Option<usize> {
self.partition.copied()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]